feat: refactor uint #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd from_bytes easier
dreamATD
reviewed
Jul 12, 2024
dreamATD
approved these changes
Jul 15, 2024
yczhangsjtu
pushed a commit
that referenced
this pull request
Aug 12, 2024
* confirm const across file impl * implement try from cell_id's to uint * add test for uint from cell ids * add documentation * document N_OPERAND_CELLS constant * wip * test cell repacking * add documentation * update packing test, ensure remaining values are 0s * add more uint instantiation methods * add test placeholders * sketch base plan for cmp * implement and test pad cells * modify from_range and from_bytes to use cell padding * extract logic for uint from arbitrary cell_width to make from_range and from_bytes easier * add compile time evaluated min function * introduce new constant cleans up uint_from* * update uint from cell id test to test greater than N_OPERANDS * add test for uint from different sized cells * implement add_unsafe * add functions sketch * wip * all func * building * test compiling * use range checker * refactor constants second pass * document cmp * wip * arithmetic second pass * delete old uint * refactor arithmetic * fix documentation * add test for add * test add constant unsafe * add test for add_small_unsafe * implement handle borrow * test sub_unsafe * rename add_small to add_cell * wip * change uint mod management * setup structure for namespacing constants * refactor counter vector implementation * move add specific constants to AddSub block * fix comment arithmetic precedence * wip * use range cells instead of range cells no overflow * add optimization comment * wip * rename witness extractors * fix test building * wip * wip * fix bugs: correct convert_decomp endian and timestamp cmp witness size * rename uint module before merge * rename uint_new back to uint * cleanup pr --------- Co-authored-by: dreamATD <[email protected]>
hero78119
pushed a commit
that referenced
this pull request
Sep 30, 2024
* confirm const across file impl * implement try from cell_id's to uint * add test for uint from cell ids * add documentation * document N_OPERAND_CELLS constant * wip * test cell repacking * add documentation * update packing test, ensure remaining values are 0s * add more uint instantiation methods * add test placeholders * sketch base plan for cmp * implement and test pad cells * modify from_range and from_bytes to use cell padding * extract logic for uint from arbitrary cell_width to make from_range and from_bytes easier * add compile time evaluated min function * introduce new constant cleans up uint_from* * update uint from cell id test to test greater than N_OPERANDS * add test for uint from different sized cells * implement add_unsafe * add functions sketch * wip * all func * building * test compiling * use range checker * refactor constants second pass * document cmp * wip * arithmetic second pass * delete old uint * refactor arithmetic * fix documentation * add test for add * test add constant unsafe * add test for add_small_unsafe * implement handle borrow * test sub_unsafe * rename add_small to add_cell * wip * change uint mod management * setup structure for namespacing constants * refactor counter vector implementation * move add specific constants to AddSub block * fix comment arithmetic precedence * wip * use range cells instead of range cells no overflow * add optimization comment * wip * rename witness extractors * fix test building * wip * wip * fix bugs: correct convert_decomp endian and timestamp cmp witness size * rename uint module before merge * rename uint_new back to uint * cleanup pr --------- Co-authored-by: dreamATD <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Goals